filter: Read all metadata columns when query parsing fails #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
In the case that column names cannot be extracted from the query, read all columns from the metadata. The behavior in this case is comparable to the behavior prior to "filter: Read a subset of metadata columns" (d0f36a1).
victorlin
force-pushed
the
victorlin/restore-reading-all-columns
branch
from
a207276
to
4e4f0d2
Compare
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
+ Coverage 68.39% 68.42% +0.03%
==========================================
Files 69 69
Lines 7517 7519 +2
Branches 1843 1843
==========================================
+ Hits 5141 5145 +4
+ Misses 2092 2091 -1
+ Partials 284 283 -1 ☔ View full report in Codecov by Sentry. |
tsibley
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In the case that column names cannot be extracted from the query, read all columns from the metadata. The behavior in this case is comparable to the behavior prior to "filter: Read a subset of metadata columns" (d0f36a1).
Related issue(s)
--querybroken with backtick quoting #1415Checklist