Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Newick parsing #69

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Improve Newick parsing #69

merged 1 commit into from
Nov 2, 2023

Commits on Nov 2, 2023

  1. Improve Newick parsing

    Replaces the basic Newick parser with an external one that handles
    single-quoted node names.  Quoted names are allowed by the format¹ and
    occur in trees produced by NCBI Pathogens.²
    
    The parser's API is a little awkward for our use case, but it's
    perfectly workable.  Out of several parsers I tried on NPM, this was the
    only one which handled quoted names, so use it despite the slightly
    awkward API.
    
    ¹ See <https://en.wikipedia.org/wiki/Newick_format#Notes> for lack of
      any formal spec.
    
    ² <https://discussion.nextstrain.org/t/displaying-trees-from-ncbi-pathogen-browser-in-auspice-us/1456>
    tsibley committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cabba98 View commit details
    Browse the repository at this point in the history