Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in deploy after version 1.16.0 #62

Closed
trvrb opened this issue Mar 15, 2020 · 3 comments · Fixed by #63
Closed

Bug in deploy after version 1.16.0 #62

trvrb opened this issue Mar 15, 2020 · 3 comments · Fixed by #63
Assignees
Labels
bug Something isn't working

Comments

@trvrb
Copy link
Member

trvrb commented Mar 15, 2020

There seems to be an issue with JSON deployment in version 1.16.0 and 1.16.1. Here are the results of running nextstrain deploy s3://nextstrain-data auspice/ncov_* with different versions of the CLI:

Not exactly sure what's going on here.

@trvrb trvrb added the bug Something isn't working label Mar 15, 2020
@tsibley
Copy link
Member

tsibley commented Mar 15, 2020

@trvrb Can you upload the source JSON files you were using? Nevermind, I can replicate with the ncov_test1.15.0.json you uploaded to S3.

@tsibley
Copy link
Member

tsibley commented Mar 15, 2020

As I suspected given the changes documented between 1.15.0 and 1.16.0, this bisects to c55d1a3.

@tsibley tsibley self-assigned this Mar 15, 2020
@tsibley
Copy link
Member

tsibley commented Mar 15, 2020

I have a fix for this which I'll finish up and make a PR for tonight or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants