Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Pyright test #340

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix failing Pyright test #340

merged 1 commit into from
Dec 19, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 19, 2023

Description of proposed changes

See commit message.

Related issue(s)

CI failing

Checklist

  • Checks pass

Without this change, there is a new check in Pyright version 1.1.341
that fails:

    Argument of type "str | None" cannot be assigned to parameter "val" of type "_HeaderTypeParam" in function "__setitem__"
@victorlin victorlin self-assigned this Dec 19, 2023
@victorlin victorlin marked this pull request as ready for review December 19, 2023 22:38
@victorlin
Copy link
Member Author

Merging to have passing CI.

@victorlin victorlin merged commit b7b8aef into master Dec 19, 2023
36 checks passed
@victorlin victorlin deleted the victorlin/fix-pyright branch December 19, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant