Officially support Python 3.12 #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove setup.py code irrelevant since 3.6/3.7 were dropped in #327
genehack
approved these changes
Apr 30, 2024
tsibley
requested changes
May 1, 2024
| @@ -13,6 +13,16 @@ development source code and as such may not be routinely kept up to date. | |||
|
|
|||
| # __NEXT__ | |||
|
|
|||
| This release adds support for Python version 3.12. | |||
| ([#TBD](https://github.com/nextstrain/cli/pull/TBD)) | |||
|
|
||
| Note that this Python version support only matters if you're installing | ||
| Nextstrain CLI from PyPI or Bioconda | ||
| ([c.f.](https://docs.nextstrain.org/projects/cli/en/8.3.0/installation/)). It |
There was a problem hiding this comment.
This link shouldn't be version-specific here. It should at least be version-agnostic
Suggested change
| ([c.f.](https://docs.nextstrain.org/projects/cli/en/8.3.0/installation/)). It | |
| ([c.f.](https://docs.nextstrain.org/projects/cli/page/installation/)). It |
or, better yet, reflect the version it's released as
Suggested change
| ([c.f.](https://docs.nextstrain.org/projects/cli/en/8.3.0/installation/)). It | |
| ([c.f.](https://docs.nextstrain.org/projects/cli/en/__NEXT__/installation/)). It |
(See c05b044 for how that works.)
Comment on lines
-148
to
+149
| "types-requests; python_version != '3.6'", | ||
| "types-requests <=2.28.11.12; python_version == '3.6'", | ||
| "types-requests", |
|
Closing in favor of #369. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Related issue(s)
Checklist