[AWS Batch] Support overriding the container image used #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for re-using it in the AWS Batch runner.
Shows the behaviour of the function better with regard to the implicit "latest" tag and will serve as automated tests once another topic branch adding doctesting is merged.
Job definitions are dynamically created as needed based on the base definition specified by --aws-batch-job. This is necessary to allow runtime-configurable images since, unlike CPUs, memory, env vars, etc, a submitted job may not directly override the container image set in the job definition. Resolves #57. Implementation originally started as PR #73. Co-authored-by: Julien BORDELLIER <git@julienbordellier.com>
joverlee521
approved these changes
May 28, 2020
Comment on lines
+296
to
+298
| "Expected job definition «%s», derived from «%s», to use image «%s», " | ||
| "but it uses «%s» instead" | ||
| % (derived_definition_name, base_definition_name, image, derived_image)) |
There was a problem hiding this comment.
Just out of curiosity, why use %s instead of .format()? (Looks like %s is used for string formatting for most of this repo)
There was a problem hiding this comment.
Astute observation! I find .format() slightly clunkier than printf-style most of the time, so tend not to use it. Just pure preference! I prefer f-strings the most, but those aren't supported until Python 3.6 and this project currently documents support for 3.5. Python 3.5 was still somewhat common on Linux computers when I was first starting this project in 2018. When this project moves to 3.6 or higher as a minimum Python version, I'd like to move to f-strings.
kairstenfay
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job definitions are dynamically created as needed based on the base
definition specified by
--aws-batch-job. This is necessary to allowruntime-configurable images since, unlike CPUs, memory, env vars, etc, a
submitted job may not directly override the container image set in the
job definition.
Resolves #57. Implementation originally started as PR #73.
Co-authored-by: Julien BORDELLIER