New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why pin hierarchy? #9

Closed

rneher opened this issue Jan 4, 2022 · 1 comment · Fixed by #10

Labels

bug

Member

rneher commented Jan 4, 2022

doesn't this pin require manual updates of the code whenever we add a new clade? @corneliusroemer

https://github.com/nextstrain/ncov-clades-schema/blob/master/src/generate_clades_json.py#L10

rneher added the bug label

Member

corneliusroemer commented Jan 4, 2022

Ah, I wrote this when the clade hierarchy wasn't yet merged into master. Now it should just point at master.

corneliusroemer mentioned this issue

fix: read hierarchy from master #10

Merged

corneliusroemer closed this as completed in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment