Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build Docker image #413

Closed
victorlin opened this issue Jul 31, 2023 · 1 comment · Fixed by #416
Closed

Unable to build Docker image #413

victorlin opened this issue Jul 31, 2023 · 1 comment · Fixed by #416
Labels
bug Something isn't working

Comments

@victorlin
Copy link
Member

I ran update-image.yml on master and it failed while running pipenv sync in the Docker build.

ValueError: "Requirement" object has no field "use_pep517"

Others on the internet have reported that this error comes from a version of PyYAML (which is included in the Pipfile.lock).

I tried re-generating the lock file using pipenv lock locally but it failed.

@victorlin victorlin added the bug Something isn't working label Jul 31, 2023
@victorlin victorlin mentioned this issue Jul 31, 2023
4 tasks
@tsibley
Copy link
Member

tsibley commented Aug 4, 2023

I haven't dug, so this is a guess, but I'm guessing this issue is restricted to Pipenv and the same version of PyYAML would be fine with standard Pip. If so, that's all the more reason to ditch Pipenv, like we've done elsewhere. If we need strict locking, we can use pip-compile from pip-tools, as elsewhere.

@victorlin victorlin mentioned this issue Aug 11, 2023
3 tasks
victorlin added a commit that referenced this issue Aug 14, 2023
The previous setup using Pipenv started failing on `pipenv sync` without
any obvious changes on our end¹.

Instead of trying to fix the Pipenv setup, I chose to move the
dependencies from the Pipfile into a simpler pip install. This
lets pip do its own dependency resolution which is sufficient for the
needs here.

¹ #413
victorlin added a commit that referenced this issue Aug 19, 2023
The previous setup using Pipenv started failing on `pipenv sync` without
any obvious changes on our end¹.

Instead of trying to fix the Pipenv setup, I chose to move the
dependencies from the Pipfile into a simpler requirements.txt. This lets
pip do its own dependency resolution which is sufficient for the needs
here.

¹ #413
victorlin added a commit that referenced this issue Feb 20, 2024
The previous setup using Pipenv started failing on `pipenv sync` without
any obvious changes on our end¹.

Instead of trying to fix the Pipenv setup, I chose to move the
dependencies from the Pipfile into a simpler requirements.txt. This lets
pip do its own dependency resolution which is sufficient for the needs
here.

¹ #413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants