Remove GenBank metadata diff #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `csv-diff` within `notify-on-metadata-change` began running into a MemoryError on December 26, 2021. This was patched during the holidays by increasing the memory for Genbank ingest runs (bd2c2ca). Further investigation showed that we have not been receiving the metadata diff output files since we switched to Snakemake on December 1, 2021 (74de8b1). The `upload` rule has been running before `notify_genbank` resulting in diffing of the same file that has been uploaded to S3. This is caused by `upload` not having any dependencies on `notify_genbank` and `notify_genbank` having an additional dependency on `check_locations`. This prompted an internal discussion that showed no one has been using the outputs of this metadata diff.
|
Tested locally that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
csv-diffwithinnotify-on-metadata-changebegan running intoa MemoryError on December 26, 2021. This was patched during the holidays
by increasing the memory for Genbank ingest runs (bd2c2ca).
Further investigation showed that we have not been receiving the
metadata diff output files since we switched to Snakemake on
December 1, 2021 (74de8b1). The
uploadrule has been running beforenotify_genbankresulting in diffing of the same file that has beenuploaded to S3. This is caused by
uploadnot having any dependencieson
notify_genbankandnotify_genbankhaving an additional dependencyon
check_locations. This prompted an internal discussion that showedno one has been using the outputs of this metadata diff.