Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduce genome length from root sequence length #36

Closed
ivan-aksamentov opened this issue Jun 28, 2020 · 0 comments · Fixed by #214
Closed

Deduce genome length from root sequence length #36

ivan-aksamentov opened this issue Jun 28, 2020 · 0 comments · Fixed by #214
Labels
good first issue Good for newcomers help wanted Extra attention is needed t:feat Type: request of a new feature, functionality, enchancement

Comments

@ivan-aksamentov
Copy link
Member

Currently it's hardcoded in a constant.
However we want to support multiple viruses in the future, so this should be dynamic.
The best way is probably to take the length of the root (reference) sequence.
@ivan-aksamentov ivan-aksamentov added t:feat Type: request of a new feature, functionality, enchancement good first issue Good for newcomers help wanted Extra attention is needed labels Jun 28, 2020
@ivan-aksamentov ivan-aksamentov mentioned this issue Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed t:feat Type: request of a new feature, functionality, enchancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Isolate virus-specific code and data nextstrain/nextclade
1 participant
@ivan-aksamentov