fix(components): isdisabled does not disable dropdown (#2435)

nextui-org · Mar 3, 2024 · 9b27da5 · toxsick · Mar 5, 2024 · kuri-sun
1 parent 5528ccd
commit 9b27da5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/two-lobsters-sip.md b/.changeset/two-lobsters-sip.md
@@ -0,0 +1,5 @@
+---
+"@nextui-org/dropdown": major
+---
+
+Fixed the bug: isDisabled does not disable dropdown
diff --git a/packages/components/dropdown/src/use-dropdown.ts b/packages/components/dropdown/src/use-dropdown.ts
@@ -119,15 +119,15 @@ export function useDropdown(props: UseDropdownProps) {
   });
 
   const getMenuTriggerProps: PropGetter = (
-    props = {},
+    originalProps = {},
     _ref: Ref<any> | null | undefined = null,
   ) => {
     // These props are not needed for the menu trigger since it is handled by the popover trigger.
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const {onKeyDown, onPress, onPressStart, ...otherMenuTriggerProps} = menuTriggerProps;
 
     return {
-      ...mergeProps(otherMenuTriggerProps, props),
+      ...mergeProps(otherMenuTriggerProps, {isDisabled: props.isDisabled, originalProps}),
       ref: mergeRefs(_ref, triggerRef),
     };
   };