fix(components): isdisabled does not disable dropdown #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6db752b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@kuri-sun is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
kuri-sun
commented
Mar 3, 2024
| @@ -119,15 +119,15 @@ export function useDropdown(props: UseDropdownProps) { | |||
| }); | |||
|
|
|||
| const getMenuTriggerProps: PropGetter = ( | |||
| props = {}, | |||
| originalProps = {}, | |||
| _ref: Ref<any> | null | undefined = null, | |||
| ) => { | |||
| // These props are not needed for the menu trigger since it is handled by the popover trigger. | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| const {onKeyDown, onPress, onPressStart, ...otherMenuTriggerProps} = menuTriggerProps; | |||
|
|
|||
| return { | |||
There was a problem hiding this comment.
It is important here to use props.isDisabled so that the PopoverTrigger component can respect another isDisabled gets passed by the user. (Otherwise, the unit test is going to fail.)
jrgarciadev
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2276
📝 Description
Based on the docs, adding an isDisabled prop and setting it to true does not disable a dropdown
⛳️ Current behavior (updates)
The
isDisabledprop does not work, because the Dropdown component does not pass theisDisabledprop to the PopoverTrigger component.🚀 New behavior
It disables the trigger when
isDisabledprop gets passed.Screen.Recording.2024-03-03.at.8.21.55.AM.mov
💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information
N/A