Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tsup, use tsc instead #1976

Closed
wants to merge 6 commits into from

Conversation

remorses
Copy link
Contributor

@remorses remorses commented Nov 14, 2023

I wanted to open a PR to enable declarationMap to make cmd+click navigate to the source code instead of the .d.ts files but i noticed that tsup doesn't support it

Tsup has a lot of other problems and unnecessary bloat

So i opened a PR to use tsc instead of tsup

Description

  • Replaced all build scripts with tsc
  • Removed dev scripts given that in development the packages "main" is set to the index.ts files for all packages, making it unnecessary
  • Removed build:fast scripts for the same reason
  • Removed tsup.config.ts
  • Added src to npm files
  • Added "use client" to all packages index.ts files given that tsc doesn't have a banner option

Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: 171a6af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 14, 2023

@remorses is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ❌ Failed (Inspect) Nov 14, 2023 5:37pm

@wingkwong
Copy link
Member

Closing due to inactivity.

@wingkwong wingkwong closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants