Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXcharacterization needs proper documentation #177

Closed
stuartcampbell opened this issue May 5, 2014 · 6 comments
Closed

NXcharacterization needs proper documentation #177

stuartcampbell opened this issue May 5, 2014 · 6 comments
Labels
bug definitions telco
Milestone
NXDL 3.3

Comments

@stuartcampbell
Copy link
Member

Original reporter: prjemian

The documentation in the NXcharacterization NXDL file is incorrect. It reveals the NXDL was created by first copying NXentry but the documentation string was never changed.
@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

(In [784]) refs #177

@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

Should this definition be removed?
It is used in:

  • base_classes/NXdetector.nxdl.xml: <group type="NXcharacterization" />
  • base_classes/NXentry.nxdl.xml: <group type="NXcharacterization" />
  • base_classes/NXsubentry.nxdl.xml: <group type="NXcharacterization" />

@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

In [1017]:

#CommitTicketReference repository="" revision="1017"
refs #177

@stuartcampbell
Copy link
Member Author

Original reporter: prjemian

In [1087]:

#CommitTicketReference repository="" revision="1087"
refs #177

prjemian added a commit that referenced this issue Jun 4, 2014
@prjemian
refs #177
5c46746
@zjttoefs
Copy link
Contributor

The class has been marked for deletion. There is no evidence of it being used and no one appears to have an idea of the intended use. The class definition is no help either. I would suggest we just delete this class.

@prjemian
Copy link
Contributor

discuss at next 2017-01-30 Telco

@prjemian prjemian added the telco label Jan 17, 2017
@prjemian prjemian modified the milestones: NeXus definitions 3.3, NXDL 3.2 Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug definitions telco
Projects
None yet
Milestone
NXDL 3.3
Development

No branches or pull requests
3 participants
@stuartcampbell @zjttoefs @prjemian