Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multiple prop to the InternalDropdown component #1596

Closed
TahimiLeonBravo opened this issue Jun 2, 2020 · 0 comments · Fixed by #1605
Closed

feat: add multiple prop to the InternalDropdown component #1596

TahimiLeonBravo opened this issue Jun 2, 2020 · 0 comments · Fixed by #1605
Assignees
@HellWolf93
Labels
2 coins enhancements
Projects
React Rainbow Components

Comments

@TahimiLeonBravo
Copy link
Collaborator

TahimiLeonBravo commented Jun 2, 2020 •
edited
Loading

Requirements

  • add multi-selection logic
@TahimiLeonBravo TahimiLeonBravo created this issue from a note in React Rainbow Components (To do (defined)) Jun 2, 2020
@TahimiLeonBravo TahimiLeonBravo moved this from To do (defined) to In progress in React Rainbow Components Jun 3, 2020
HellWolf93 added a commit to HellWolf93/react-rainbow that referenced this issue Jun 4, 2020
@HellWolf93
feat: add multiple prop to the InternalDropdown component
6211851 
fix: nexxtway#1596
@HellWolf93 HellWolf93 mentioned this issue Jun 4, 2020
Merged
1 task
React Rainbow Components automation moved this from In progress to QA Jun 4, 2020
reiniergs pushed a commit that referenced this issue Jun 4, 2020
@HellWolf93
feat: add multiple prop to the InternalDropdown component (#1605)
43768ca 
* feat: add `multiple` prop to the `InternalDropdown` component

fix: #1596

* fix: refactor getValueNames function

* fix: reuse handleChange in key enter handler
@TahimiLeonBravo TahimiLeonBravo moved this from QA to Done in React Rainbow Components Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HellWolf93 HellWolf93

Labels
2 coins enhancements
Projects
React Rainbow Components
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add multiple prop to the InternalDropdown component HellWolf93/react-rainbow
2 participants
@HellWolf93 @TahimiLeonBravo