Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multiple prop to the InternalDropdown component #1605

Merged
merged 3 commits into from
Jun 4, 2020
Merged

feat: add multiple prop to the InternalDropdown component #1605

merged 3 commits into from
Jun 4, 2020

Conversation

HellWolf93
Copy link
Collaborator

fix: #1596

Changes proposed in this PR:

@commit-lint
Copy link

commit-lint bot commented Jun 4, 2020 •
edited
Loading

Features

  • add multiple prop to the InternalDropdown component (6211851)

Bug Fixes

  • refactor getValueNames function (5e1fdc7)
  • reuse handleChange in key enter handler (b181457)

Contributors

@HellWolf93

@reiniergs
Copy link
Collaborator

@HellWolf93 I don't see test for the component, are you gonna write integration tests for multiple selection??

/cc @TahimiLeonBravo @LeandroTorresSicilia

reiniergs
reiniergs approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@reiniergs reiniergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@reiniergs reiniergs merged commit 43768ca into nexxtway:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiniergs reiniergs reiniergs approved these changes

@LeandroTorresSicilia LeandroTorresSicilia Awaiting requested review from LeandroTorresSicilia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add multiple prop to the InternalDropdown component
2 participants
@HellWolf93 @reiniergs