fix: tabset component with only one tab #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributors@gerardolgvr, @LeandroTorresSicilia Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
|
|
gerardolgvr
force-pushed
the
fix-tabset-when-only-have-one-tab
branch
from
2d509be
to
e7ac1aa
Compare
maxxgreene
reviewed
Jun 29, 2020
LeandroTorresSicilia
approved these changes
Jun 30, 2020
|
@gerardolgvr Good job! |
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: tabset component with only one tab
fix: #1667
Changes proposed in this PR:
The problem was at the function "IsNotSameChildren" at utils.js (Tabset component). This function is expecting an array of objects but when a single tab is given the parameter that receives that function is an object. So, method ".some" is available for arrays but when an object is received an error occurs.
A new check was added to make the proper comparation
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow