-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the page crash when Tabset
component have only one Tab
#1667
Comments
Tabset
component is broken when only one Tab is passedTabset
component have only one Tab
Hello! Can I try to fix this issue? |
@gerardolgvr You are welcome :) |
Thanks, I think I found the solution to this issue. The problem was at the function "IsNotSameChildren" at utils.js. This function is expecting an array of objects but when a single tab is given the parameter that receives that function is an object. So, method .some is available for arrays but when an object is received an error occurs. I have updated the function to check when an object is passed to the function to make the proper comparation. The tests associated to this component runs without problems :) I think its a good moment to make a pr and check if it seems ok for you or if some changes are required 😊 |
The text was updated successfully, but these errors were encountered: