-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keyboard navigation to Tree component #1781
Merged
LeandroTorresSicilia
merged 21 commits into
master
from
implement-tree-component-keyborad-navigation
Aug 15, 2020
Merged
feat: add keyboard navigation to Tree component #1781
LeandroTorresSicilia
merged 21 commits into
master
from
implement-tree-component-keyborad-navigation
Aug 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Bug Fixes
Tests
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
When the tree gets the focus, if we press tab key then the focus should move to the next page element, now it gets stuck in the Tree, we should add test to this behavior |
Code Climate has analyzed commit 9fdc2dc and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1738
Changes proposed in this PR:
add keyboard navigation to Tree component
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow