Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keyboard navigation to Tree component #1781

Merged

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Aug 8, 2020

fix: #1738

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Aug 8, 2020

Features

  • add keyboard navigation to Tree component (43552b4)
  • add find node by typing a letter and expand all nodes at same level (0871c57)

Bug Fixes

  • fix failing tests (693cd7b)
  • fix tree behaviour when space is pressed on expandable nodes (7aad7e4)
  • fix behaviour when press ENTER key (fcbfeea)
  • remove using event.stopPropagation (58e2514)
  • fix behaviour when Enter key is pressed (6dda543)
  • fix helper name (4c42cd4)
  • fix issue with tab key (4c9eb37)
  • minos code style issue (b820299)
  • fix context usage (4016827)
  • rename context callbacks (9fdc2dc)

Tests

  • comment some failing tests (a7a0ca4)
  • add test for some helper functions (f45dbca)
  • add more test for helpers (384492e)
  • fix child component tests (47527bf)

Contributors

@wildergd

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

src/components/Tree/child.js Outdated Show resolved Hide resolved
src/components/Tree/helpers/getTabIndex.js Show resolved Hide resolved
src/components/Tree/child.js Outdated Show resolved Hide resolved
src/components/Tree/hooks/useKeyNavigation.js Show resolved Hide resolved
src/components/Tree/hooks/useKeyNavigation.js Show resolved Hide resolved
integration/specs/Tree/tree-1.spec.js Outdated Show resolved Hide resolved
integration/specs/Tree/tree-1.spec.js Outdated Show resolved Hide resolved
integration/specs/Tree/tree-1.spec.js Outdated Show resolved Hide resolved
integration/specs/Tree/tree-1.spec.js Outdated Show resolved Hide resolved
@LeandroTorresSicilia
Copy link
Member

When the tree gets the focus, if we press tab key then the focus should move to the next page element, now it gets stuck in the Tree, we should add test to this behavior

@codeclimate
Copy link

codeclimate bot commented Aug 14, 2020

Code Climate has analyzed commit 9fdc2dc and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4
Duplication 6

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 508680b into master Aug 15, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the implement-tree-component-keyborad-navigation branch August 15, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement keyboard navigation on the Tree component
2 participants