-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add integration tests for arrow navigation in Calendar and Tree components #1788
Merged
LeandroTorresSicilia
merged 12 commits into
master
from
test-integration-of-calendar-and-tree-keyboard-navigation
Aug 21, 2020
Merged
test: add integration tests for arrow navigation in Calendar and Tree components #1788
LeandroTorresSicilia
merged 12 commits into
master
from
test-integration-of-calendar-and-tree-keyboard-navigation
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
ad9ffa6
to
a957dcf
Compare
e71f9a0
to
36e6fdd
Compare
…on' of https://github.com/90milesbridge/react-rainbow into test-integration-of-calendar-and-tree-keyboard-navigation
Code Climate has analyzed commit e2be05d and detected 20 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1740
fix: #1781
fix: #1791
Changes proposed in this PR:
add integration tests for arrow navigation in header of Calendar component
add test for keyboard navigation on the Tree component
I have followed (at least) the PR section of the contributing guide.
@nexxtway/react-rainbow