Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration tests for arrow navigation in Calendar and Tree components #1788

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Aug 17, 2020

fix: #1740
fix: #1781
fix: #1791

Changes proposed in this PR:

  • add integration tests for arrow navigation in header of Calendar component

  • add test for keyboard navigation on the Tree component

  • I have followed (at least) the PR section of the contributing guide.

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Aug 17, 2020

Tests

Bug Fixes

Contributors

@wildergd

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@wildergd wildergd changed the title test: add integration tests for arrow navigation in header of Calendar component test: add integration tests for arrow navigation in Calendar and Tree components Aug 17, 2020
@wildergd wildergd force-pushed the test-integration-of-calendar-and-tree-keyboard-navigation branch from ad9ffa6 to a957dcf Compare August 18, 2020 12:25
@wildergd wildergd force-pushed the test-integration-of-calendar-and-tree-keyboard-navigation branch from e71f9a0 to 36e6fdd Compare August 18, 2020 13:04
@codeclimate
Copy link

codeclimate bot commented Aug 21, 2020

Code Climate has analyzed commit e2be05d and detected 20 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 20

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit c69c06f into master Aug 21, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the test-integration-of-calendar-and-tree-keyboard-navigation branch August 21, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: the keyboard navigation on the Tree component
2 participants