Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll on Picklist not work inside the Drawer #1900

Merged
merged 8 commits into from
Oct 14, 2020

Conversation

wildergd
Copy link
Collaborator

@wildergd wildergd commented Oct 9, 2020

fix: #1894

Changes proposed in this PR:

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 9, 2020

Bug Fixes

  • fix picklist still opened after scroll in drawer content area (c76680b)
  • fix picklist menu closed when scroll inside dropdown (0a3c1c4)
  • fix WindowScrolling class (db793d2)
  • fix picklist menu closed when scroll page (53ca1d3)
  • remove param in scroll callback (bc74e2c)

Contributors

@wildergd, @LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@LeandroTorresSicilia
Copy link
Member

when trying to scroll inside the picklist it works only the second time, the first time continues closing the menu, also when open for the second time the picklist it does not close the menu when scrolling outside

@wildergd
Copy link
Collaborator Author

Let me check...

@codeclimate
Copy link

codeclimate bot commented Oct 14, 2020

Code Climate has analyzed commit 5930bc5 and detected 0 issues on this pull request.

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit 914144e into master Oct 14, 2020
@LeandroTorresSicilia LeandroTorresSicilia deleted the fix-picklist-hide branch October 14, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: scroll on Picklist not work inside the Drawer
2 participants