feat: add required prop to Slider component
#2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features
Documentation
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| expect(component.find('input').prop('required')).toBe(true); | ||
| }); | ||
|
|
||
| it('should render required asterisk when required prop is true', () => { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
Visit the preview URL for this PR (updated for commit 1ecf873): https://react-rainbow--pr2297-slider-add-required-1xpt0fmo.web.app (expires Thu, 14 Oct 2021 14:10:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
HellWolf93
changed the title
required prop to Slider component
LeandroTorresSicilia
approved these changes
Oct 7, 2021
TahimiLeonBravo
approved these changes
Oct 7, 2021
|
Code Climate has analyzed commit 1ecf873 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2295
Changes proposed in this PR:
Add
requiredprop to Slider componentImprove Slider components docs
I have followed (at least) the PR section of the contributing guide.