feat: add input and all inputable components prop size #2463

yvmunayev · 2022-10-01T17:58:40Z

fix: #2462

Changes proposed in this PR:

feat: add input and all inputable components prop size
I have followed (at least) the PR section of the contributing guide.

@nexxtway/react-rainbow

commit-lint · 2022-10-01T17:58:44Z

Features

add input component prop size (dc25d9b)
add password input component prop size (2b5b73e)
add date picker component prop size (40938d2)
add date time picker component prop size (79ef194)
add time picker component prop size (b7fefb2)
add checkbox component prop size (4416818)
add radio input component prop size (f5e8fac)
add checkbox group component prop size (d87e038)
add radio group component prop size (eb8360b)

Bug Fixes

remove size to checkbox and radio button (bc41024)
size description (391fd84)

Contributors

yvmunayev

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

github-actions · 2022-10-01T18:02:48Z

Visit the preview URL for this PR (updated for commit 391fd84):

https://react-rainbow--pr2463-feat-add-input-and-a-9r6pk514.web.app

_{(expires Fri, 14 Oct 2022 00:41:46 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

…to feat-add-input-and-all-inputable-components-prop-size

LeandroTorresSicilia · 2022-10-06T23:01:14Z

src/components/CheckboxGroup/checkboxList.js

@@ -7,7 +7,7 @@ import StyledItemDescription from '../RadioGroup/styled/itemDescription';
 import RenderIf from '../RenderIf';

 export default function CheckboxList(props) {
-    const { values, options, onChange, describedBy, name, error } = props;
+    const { values, options, onChange, describedBy, name, error, size } = props;


here in this component we will not add this for now

LeandroTorresSicilia · 2022-10-06T23:06:24Z

src/components/DatePicker/index.js

@@ -219,6 +221,8 @@ DatePicker.propTypes = {
    disabledDays: PropTypes.arrayOf(
        PropTypes.oneOfType([PropTypes.string, PropTypes.instanceOf(Date)]),
    ),
+    /** The size of the input. Valid values are small, and large. */


are small, medium, and large.

LeandroTorresSicilia · 2022-10-06T23:08:10Z

src/components/DateTimePicker/index.js

@@ -222,6 +224,8 @@ DateTimePicker.propTypes = {
    disabledDays: PropTypes.arrayOf(
        PropTypes.oneOfType([PropTypes.string, PropTypes.instanceOf(Date)]),
    ),
+    /** The size of the input. Valid values are small, and large. */


LeandroTorresSicilia · 2022-10-06T23:11:21Z

src/components/Input/checkboxRadioLabel/index.js

@@ -18,7 +18,9 @@ export default function Label(props) {
    return (
        <label htmlFor={inputId} id={id}>
            <span className="rainbow-input_faux" />
-            <StyledLabelText disabled={disabled}>{label}</StyledLabelText>
+            <StyledLabelText disabled={disabled} size={size}>


same ^^ I think we don't need this here for now

LeandroTorresSicilia · 2022-10-06T23:11:37Z

src/components/Input/checkboxRadioLabel/labelText.js

+        props.size === 'small' &&
+        `
+            font-size: ${FONT_SIZE_TEXT_MEDIUM};
+        `};


LeandroTorresSicilia · 2022-10-06T23:12:07Z

src/components/Input/index.js

@@ -147,6 +147,8 @@ Input.propTypes = {
     *
     * For a detailed list, go to: https://www.w3.org/TR/WCAG21/#input-purposes */
    autoComplete: PropTypes.string,
+    /** The size of the input. Valid values are small, and large. */


small, medium, and large

LeandroTorresSicilia · 2022-10-06T23:14:23Z

src/components/Input/inputCheckbox/checkbox.js

@@ -75,13 +76,15 @@ export default class Checkbox extends Component {
                    aria-describedby={ariaDescribedBy}
                    ref={this.inputRef}
                    error={error}
+                    size={size}


not for now here in checkbox

LeandroTorresSicilia · 2022-10-06T23:14:52Z

src/components/Input/inputCheckbox/index.js

@@ -96,6 +97,7 @@ export default class InputCheckbox extends Component {
                    error={error}
                    label={label}
                    hideLabel={hideLabel}
+                    size={size}


LeandroTorresSicilia · 2022-10-06T23:15:01Z

src/components/Input/inputCheckbox/styled/checkbox.js

+            `
+            width: 18px;
+            height: 18px;
+            `};


LeandroTorresSicilia · 2022-10-06T23:15:14Z

src/components/Input/inputRadio/index.js

@@ -74,6 +74,7 @@ export default class InputRadio extends Component {
            name,
            checked,
            hideLabel,
+            size,


LeandroTorresSicilia · 2022-10-06T23:15:23Z

src/components/Input/inputRadio/radio.js

@@ -75,13 +76,15 @@ export default class Radio extends Component {
                    aria-describedby={ariaDescribedBy}
                    ref={this.inputRef}
                    error={error}
+                    size={size}


LeandroTorresSicilia · 2022-10-06T23:15:32Z

src/components/Input/inputRadio/styled/radio.js

+            height: 25px;
+            `};
+
+        ${props =>


codeclimate · 2022-10-07T00:39:43Z

Code Climate has analyzed commit 391fd84 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	6

View more on Code Climate.

yvmunayev added 9 commits September 27, 2022 11:45

feat: add input component prop size

dc25d9b

feat: add password input component prop size

2b5b73e

feat: add date picker component prop size

40938d2

feat: add date time picker component prop size

79ef194

feat: add time picker component prop size

b7fefb2

feat: add checkbox component prop size

4416818

feat: add radio input component prop size

f5e8fac

feat: add checkbox group component prop size

d87e038

feat: add radio group component prop size

eb8360b

Merge branch 'master' of https://github.com/nexxtway/react-rainbow in…

36d3ad0

…to feat-add-input-and-all-inputable-components-prop-size

LeandroTorresSicilia reviewed Oct 6, 2022

View reviewed changes

src/components/Input/inputCheckbox/styled/checkbox.js Outdated

`

width: 18px;

height: 18px;

`};

Copy link

Member

LeandroTorresSicilia Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same ^^

LeandroTorresSicilia reviewed Oct 6, 2022

View reviewed changes

src/components/Input/inputRadio/styled/radio.js Outdated

height: 25px;

`};

${props =>

Copy link

Member

LeandroTorresSicilia Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same ^^

yvmunayev added 2 commits October 6, 2022 20:32

fix: remove size to checkbox and radio button

bc41024

fix: size description

391fd84

LeandroTorresSicilia approved these changes Oct 7, 2022

View reviewed changes

LeandroTorresSicilia merged commit e010800 into master Oct 7, 2022

LeandroTorresSicilia deleted the feat-add-input-and-all-inputable-components-prop-size branch October 7, 2022 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add input and all inputable components prop size #2463

feat: add input and all inputable components prop size #2463

yvmunayev commented Oct 1, 2022

commit-lint bot commented Oct 1, 2022 •

edited

Loading

github-actions bot commented Oct 1, 2022 •

edited

Loading

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

LeandroTorresSicilia Oct 6, 2022

codeclimate bot commented Oct 7, 2022

feat: add input and all inputable components prop size #2463

feat: add input and all inputable components prop size #2463

Conversation

yvmunayev commented Oct 1, 2022

Changes proposed in this PR:

commit-lint bot commented Oct 1, 2022 • edited Loading

Features

Bug Fixes

Contributors

github-actions bot commented Oct 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 7, 2022

commit-lint bot commented Oct 1, 2022 •

edited

Loading

github-actions bot commented Oct 1, 2022 •

edited

Loading