Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add border radius radius prop to button icon #2496

Merged

Conversation

adrianestevez1
Copy link
Contributor

fix: #2494

Changes proposed in this PR:

-Add borderRadius prop to ButtonIcon component

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Oct 21, 2022

Features

  • add borderRadius prop to ButtonIcon component (4d14fa7)
  • add borderRadius prop to ButtonIcon component (99481bc)

Contributors

LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LeandroTorresSicilia
❌ Adrian Estevez


Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Oct 21, 2022

Visit the preview URL for this PR (updated for commit 1795a64):

https://react-rainbow--pr2496-add-border-radius-ra-we110g5s.web.app

(expires Tue, 01 Nov 2022 15:14:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

@adrianestevez1 adrianestevez1 changed the title Add border radius radius prop to button icon feat: add border radius radius prop to button icon Oct 21, 2022
@LeandroTorresSicilia
Copy link
Member

@adrianestevez1 add type to index.d.ts

@adrianestevez1 adrianestevez1 force-pushed the add-border-radius-radius-prop-to-button-icon branch from 76c98ab to f524a21 Compare October 24, 2022 19:07
@codeclimate
Copy link

codeclimate bot commented Oct 24, 2022

Code Climate has analyzed commit f524a21 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@LeandroTorresSicilia LeandroTorresSicilia merged commit d72f26a into master Oct 25, 2022
@LeandroTorresSicilia LeandroTorresSicilia deleted the add-border-radius-radius-prop-to-button-icon branch October 25, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add borderRadius prop to ButtonIcon component
3 participants