-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tabset for react 18 #2513
fix: tabset for react 18 #2513
Conversation
Bug FixesContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Visit the preview URL for this PR (updated for commit d6bbdfd): https://react-rainbow--pr2513-fix-tabset-react-18-iql9p6p1.web.app (expires Mon, 07 Nov 2022 00:11:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2de6d670498a0a515484c5637b13d0215372df83 |
@@ -129,12 +129,13 @@ describe('<Tabset />', () => { | |||
); | |||
component.instance().updateButtonsVisibility = jest.fn(); | |||
expect(component.instance().isFirstTime).toBe(true); | |||
component.instance().tabsetChildren = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 2 locations. Consider refactoring.
@@ -178,12 +179,13 @@ describe('<Tabset />', () => { | |||
</Tabset>, | |||
); | |||
component.instance().tabsetRef.current = { offsetWidth: 500 }; | |||
component.instance().tabsetChildren = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identical blocks of code found in 2 locations. Consider refactoring.
Code Climate has analyzed commit d6bbdfd and detected 12 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
fix: #2512