Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar component #524

Merged
merged 18 commits into from
Jan 13, 2019
Merged

Sidebar component #524

merged 18 commits into from
Jan 13, 2019

Conversation

daren-k
Copy link
Collaborator

@daren-k daren-k commented Jan 11, 2019

New sidebar component and global icons added

@coveralls
Copy link

coveralls commented Jan 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1197

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 77.379%
Totals Coverage Status
Change from base Build 1110: 0.2%
Covered Lines: 1364
Relevant Lines: 1691
💛 - Coveralls

@TahimiLeonBravo
Copy link
Collaborator

we need to export the Sidebar and the SidebarItem components in the root index

reiniergs
reiniergs reviewed Jan 11, 2019
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
reiniergs
reiniergs reviewed Jan 11, 2019
View reviewed changes
src/components/Sidebaritem/index.js Outdated
)}
</NavigationConsumer>
);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeandroTorresSicilia is there a way to use the consumer as a high order function instead of using declarative component ??

Copy link
Member

@LeandroTorresSicilia LeandroTorresSicilia Jan 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reiniergs this is the new context API, we could just wrap it in a high order component and export the component through the HOC

@reiniergs
Copy link
Collaborator

LGTM, just minor changes

@LeandroTorresSicilia LeandroTorresSicilia merged commit 115ee18 into master Jan 13, 2019
@TahimiLeonBravo TahimiLeonBravo deleted the sidebar-component branch September 23, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiniergs reiniergs reiniergs left review comments

@LeandroTorresSicilia LeandroTorresSicilia LeandroTorresSicilia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daren-k @coveralls @TahimiLeonBravo @reiniergs @LeandroTorresSicilia