Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADONIS test #364

Merged
merged 7 commits into from Dec 22, 2021
Merged

Add ADONIS test #364

merged 7 commits into from Dec 22, 2021

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Dec 21, 2021

This is testing for metadata feature importance and significance in beta diversity distances. Quite interesting in my opinion and an easy addition within QIIME2.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Dec 21, 2021

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1ccc756

+| ✅ 139 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.2
  • Run at 2021-12-22 09:47:48

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, with a single point of possible improvement, see comment.

nextflow_schema.json Outdated Show resolved Hide resolved
@d4straub d4straub merged commit c101f0a into nf-core:dev Dec 22, 2021
@d4straub d4straub deleted the qiime2-adonis branch December 22, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants