Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Directory before output is generated for Azure. #384

Merged
merged 4 commits into from Feb 7, 2022
Merged

Make Directory before output is generated for Azure. #384

merged 4 commits into from Feb 7, 2022

Conversation

vsmalladi
Copy link
Contributor

@vsmalladi vsmalladi commented Feb 4, 2022 •
edited

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

Make Directory before output is generated for Azure. Closes #383

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • CHANGELOG.md is updated.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cc71047

+| ✅ 139 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.2
  • Run at 2022-02-07 15:28:45

@vsmalladi vsmalladi linked an issue Feb 4, 2022 that may be closed by this pull request
QIIME2_DIVERSITY_BETAORD output not recognized in Azure #383
Closed
d4straub
d4straub reviewed Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, unfortunately the Markdown test fails. I do not understand the error message, but it did pass before your second commit, so it might be related to that.

CHANGELOG.md Outdated Show resolved Hide resolved
@vsmalladi @d4straub
Update CHANGELOG.md
cc71047 
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
d4straub
d4straub approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Markdown test is bugged currently!

Thanks for contributing!

@d4straub d4straub merged commit ca7fc1b into nf-core:dev Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --fix
    • Manually resolve anything left from markdownlint .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QIIME2_DIVERSITY_BETAORD output not recognized in Azure
2 participants
@vsmalladi @d4straub