Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bytesize talk info #397

Merged
merged 4 commits into from Mar 16, 2022
Merged

add bytesize talk info #397

merged 4 commits into from Mar 16, 2022

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Mar 14, 2022

This is to add links to the bytesize slides/video and to correct typo's.

@github-actions
Copy link

github-actions bot commented Mar 14, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e6a641b

+| ✅ 138 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.2
  • Run at 2022-03-14 15:19:45

Copy link

@marissaDubbelaar marissaDubbelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@SusiJo SusiJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d4straub looks good to me! 👍
Just one question: the new flags that appear in the Changelog are not stated in the docs.
Wouldn't it make sense to add them in the usage.md?

@d4straub
Copy link
Collaborator Author

Thanks you two!

@SusiJo You are right, the new parameter and most other parameter are not mentioned in the usage.md. Those are eplained however in nextflow_schema.json, i.e. https://nf-co.re/ampliseq/dev/parameters. In usage.md describes only the most important aspects, especially input requirements.

@d4straub d4straub merged commit fb30592 into nf-core:dev Mar 16, 2022
@d4straub d4straub deleted the add-bytesize-talk branch March 16, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants