Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dada2_quality #439

Merged
merged 1 commit into from May 26, 2022
Merged

fix dada2_quality #439

merged 1 commit into from May 26, 2022

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented May 25, 2022

Closes #438

Edit: ok, confirmed the problem myself and also that this is the solution.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 25, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit bdf370a

+| ✅ 147 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-05-25 18:45:17

Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@d4straub
Copy link
Collaborator Author

Thanks!

@d4straub d4straub merged commit 0951f20 into nf-core:dev May 26, 2022
@d4straub d4straub deleted the fix-again-dada2_quality branch May 26, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants