Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export input and metadata #458

Merged
merged 2 commits into from Jul 15, 2022
Merged

Export input and metadata #458

merged 2 commits into from Jul 15, 2022

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Jul 14, 2022 •
edited

Closes #347.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@d4straub d4straub added the WIP Work in progress label Jul 14, 2022
@d4straub d4straub self-assigned this Jul 14, 2022
@github-actions
Copy link

github-actions bot commented Jul 14, 2022 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 20bd6ea

+| ✅ 147 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-14 13:21:49

@d4straub d4straub removed the WIP Work in progress label Jul 14, 2022
erikrikarddaniel
erikrikarddaniel approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@d4straub
Copy link
Collaborator Author

Thx!

@d4straub d4straub merged commit e51c2b5 into nf-core:dev Jul 15, 2022
@d4straub d4straub deleted the export-input branch July 15, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikrikarddaniel erikrikarddaniel erikrikarddaniel approved these changes

Assignees

@d4straub d4straub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d4straub @erikrikarddaniel