Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to change MACS2 parameters #107

Closed
chlazaris opened this issue Jun 13, 2020 · 2 comments
Closed

Add options to change MACS2 parameters #107

chlazaris opened this issue Jun 13, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@chlazaris
Copy link

It would be very helpful to have an option to change the MACS2 parameters for peak calling. The default ones are a good start but may not work for everything. The most important one to add would probably be the option to change (-q) (minimum FDR cutoff) and (-p) (p-value cut-off). It may also be useful to include the original MACS as peak caller. Thank you!
@drpatelh drpatelh added the enhancement New feature or request label Jun 16, 2020
drpatelh added a commit to drpatelh/nf-core-atacseq that referenced this issue Jul 1, 2020
@drpatelh
Fix nf-core#107
1063986
@drpatelh
Copy link
Member

drpatelh commented Jul 1, 2020 •
edited
Loading

Added --macs_fdr and --macs_pvalue parameters here @chlazaris 🙂

@drpatelh drpatelh closed this as completed Jul 1, 2020
@chlazaris
Copy link
Author

Thank you very much @drpatelh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chlazaris @drpatelh