Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A5-miseq support #23

Closed
vinisalazar opened this issue Mar 29, 2020 · 4 comments
Closed

Add A5-miseq support #23

vinisalazar opened this issue Mar 29, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vinisalazar
Copy link

vinisalazar commented Mar 29, 2020

Hi,

thank you for providing this pipeline.

Would you consider providing A5-miseq support for short-reads-only mode?

I normally use Spades (or Unicycler in this case), but I've consistently been getting better results with A5-miseq when assembling a short-reads-only dataset.

e.g. compare these two assemblies
bacass - unicycler:
Total n: 181
Total seq: 5473999 bp
Avg. seq: 30243.09 bp
Median seq: 1476.00 bp
N 50: 143598 bp
Min seq: 110 bp
Max seq: 623519 bp

a5-miseq:
Total n: 78
Total seq: 5532586 bp
Avg. seq: 70930.59 bp
Median seq: 4987.50 bp
N 50: 278625 bp
Min seq: 623 bp
Max seq: 761326 bp

It is not a huge difference, but I believe it would be a good addition to the pipeline. I'd love to make a PR myself, but I'm still not confident enough with Groovy/nextflow scripting.

Thank you for any assistance you can provide,

V

@apeltzer apeltzer added help wanted Extra attention is needed enhancement New feature or request labels Oct 8, 2020
@apeltzer
Copy link
Member

apeltzer commented Oct 8, 2020

I'm going to make a maintenance release these days - feel free to work on this and try to add it to the pipeline if you want to use it :-) This is open source, so you're very welcome to do so!

@vinisalazar
Copy link
Author

Thanks @apeltzer . At the moment I cannot dedicate time to this, but I would be interested to give it a try a couple of months from now. Will keep this issue updated if I do so.

@apeltzer
Copy link
Member

apeltzer commented Oct 9, 2020

Sounds good - whenever you find time :-)

@Daniel-VM
Copy link
Contributor

Closing this issue. Please feel free to reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants