Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nf-core template v2.10 #91

Merged
merged 2 commits into from Sep 26, 2023
Merged

Update nf-core template v2.10 #91

merged 2 commits into from Sep 26, 2023

Conversation

Daniel-VM
Copy link
Contributor

Description

This PR attempts update the workflow according to the nf-core template 2.10 release (#89 ).

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 72f80f6

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in README.md: update the following command to include all required parameters for a minimal example
  • pipeline_todos - TODO string in WorkflowBacass.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-26 12:50:50

d4straub
d4straub approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But I havent done the template update myself yet for other pipelines...

@Daniel-VM
Copy link
Contributor Author

Thanks!,
This one was simpler than the previous, yet the magic of nf-core tools gets the job almost done 🪄 😆

@Daniel-VM Daniel-VM merged commit 29249d2 into nf-core:dev Sep 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Daniel-VM @d4straub @nf-core-bot