Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect the module statistics to multiqc #93

Merged
merged 7 commits into from Oct 11, 2023
Merged

Redirect the module statistics to multiqc #93

merged 7 commits into from Oct 11, 2023

Conversation

Daniel-VM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).

PR description

For those supported modules in MultiQC, collect files and allow them to be summarized by the MultiQC module. Related issue #92.

@github-actions
Copy link

github-actions bot commented Oct 10, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7cd0e63

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in README.md: update the following command to include all required parameters for a minimal example
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in WorkflowBacass.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-11 13:33:29

@Daniel-VM Daniel-VM changed the title Redirect the module's stats to multiqc Redirect the module stats to multiqc Oct 10, 2023
@Daniel-VM Daniel-VM changed the title Redirect the module stats to multiqc Redirect the module statistics to multiqc Oct 10, 2023
d4straub
d4straub reviewed Oct 10, 2023
View reviewed changes
workflows/bacass.nf Outdated Show resolved Hide resolved
d4straub
d4straub reviewed Oct 10, 2023
View reviewed changes
workflows/bacass.nf Outdated Show resolved Hide resolved
d4straub
d4straub approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
But please add a note to the CHANGELOG before merging.

@Daniel-VM Daniel-VM merged commit 368c6cb into nf-core:dev Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Daniel-VM @d4straub