Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computeMatrix.val.mat.gz files not zipped #154

Closed
ivokwee opened this issue May 22, 2020 · 4 comments
Closed

computeMatrix.val.mat.gz files not zipped #154

ivokwee opened this issue May 22, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@ivokwee
Copy link

ivokwee commented May 22, 2020

Hi. The *.computeMatrix.val.mat.gz files in the deepTools module seem not to be zipped.

@drpatelh
Copy link
Member

drpatelh commented May 30, 2020

results
├── bwa
│   └── mergedLibrary
│       ├── deepTools
│       │   ├── plotFingerprint
│       │   │   ├── SPT5_T0_R1.plotFingerprint.pdf
│       │   │   ├── SPT5_T0_R1.plotFingerprint.qcmetrics.txt
│       │   │   ├── SPT5_T0_R1.plotFingerprint.raw.txt
│       │   └── plotProfile
│       │       ├── SPT5_T0_R1.computeMatrix.mat.gz
│       │       ├── SPT5_T0_R1.computeMatrix.vals.mat.gz
│       │       ├── SPT5_T0_R1.plotProfile.pdf
$ zcat SPT5_INPUT_R2.computeMatrix.vals.mat.gz | head
gzip: SPT5_INPUT_R2.computeMatrix.vals.mat.gz: not in gzip format

Yep, you are right @ivokwee 👍 Well spotted!! Ill fix that in the next release.

@drpatelh drpatelh reopened this May 30, 2020
@drpatelh drpatelh added the bug Something isn't working label May 30, 2020
@ivokwee
Copy link
Author

ivokwee commented May 30, 2020

OK. Also, the first non-commented line of these computeMatrix.vals.mat.gz files has one column too many, so reading the vals.mat files give problems/warning in R.

genes:7080 SPT5_INPUT_R1.mLb.clN SPT5_INPUT_R1.mLb.clN

This could be resolved by either removing "genes:7080" from the column names header, or adding rownames (preferred) to the matrix values, I guess.

Thanks.

Ivo

@drpatelh
Copy link
Member

Unfortunately, the format of the output file is something that I would be a little more reluctant to change because it's something that should be addressed upstream by deepTools or by scripts reading the file in - mainly for standardisation purposes. Happy to fix the naming convention though 👍

drpatelh added a commit to drpatelh/nf-core-chipseq that referenced this issue Jun 2, 2020
@drpatelh
Copy link
Member

drpatelh commented Jun 2, 2020

Fixed db3a364

@drpatelh drpatelh closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants