Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segemehl update #123

Merged
merged 2 commits into from
May 30, 2024
Merged

Segemehl update #123

merged 2 commits into from
May 30, 2024

Conversation

nictru
Copy link
Contributor

@nictru nictru commented May 30, 2024

#122 introduced a bug with segemehl. The SEGEMEHL_ALIGN process originally had a single output channel containing a list of all output files. This was manageable before #122 because a specific process called SEGEMEHL_FILTER handled this list. In #122, we switched to the nf-core GAWK module for unification (and common filtering of the unified files afterward).
The GAWK/UNIFY module then used all files from the list output of SEGEMEHL_ALIGN as input. This was problematic since not all files followed the expected input format; thus, the output of UNIFY was partially binary.

The SEGEMEHL_ALIGN process was updated via a modules PR.
This PR integrates this update into the pipeline (other nf-core modules were also updated).

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b81a30a

+| ✅ 226 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-30 12:23:45

JoseEspinosa
JoseEspinosa approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nictru nictru merged commit 0e9cce3 into dev May 30, 2024
4 checks passed
@nictru nictru deleted the segemehl-update branch May 30, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nictru @JoseEspinosa