Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Software Versions process not run if DamageProfiler skipped #237

Closed
jfy133 opened this issue Sep 14, 2019 · 5 comments
Closed

Get Software Versions process not run if DamageProfiler skipped #237

jfy133 opened this issue Sep 14, 2019 · 5 comments
Labels
bug Something isn't working needs upstream fix Needs a fix in the upstream tool project pending Addressed on branch waiting for related PR

Comments

@jfy133
Copy link
Member

jfy133 commented Sep 14, 2019

Describe the bug
If you do not have damageprofiler running in your run (with --skip_deduplication), get_software_versions process is not executed.

To Reproduce
See above

Expected behaviour
get_software_versions always run with whatever tools are accessible.

Additional context
Partly due to the awkward way of getting the DamageProfiler versions (i.e. from the log file), so must be given to the process as an input channel.

@jfy133 jfy133 added the bug Something isn't working label Sep 14, 2019
@jfy133
Copy link
Member Author

jfy133 commented Sep 14, 2019

This is also an issue for the GATK_UG branch

@jfy133
Copy link
Member Author

jfy133 commented Sep 14, 2019

Possible solution?

https://github.com/nextflow-io/patterns/blob/master/docs/optional-input.adoc

@apeltzer
Copy link
Member

Yeah, the problem is that the DamageProfiler tool doesn't write out a JSON file unfortunately with the information that we'd need at the moment. Since v0.4.6 it can do that, but MultiQC v1.8 isn't out (yet) that could parse this information automatically from the JSON that DamageProfiler nowadays creates automatically.

=> Once we have MultiQC v1.8, this will be gone immediately and we can also the same approach than with other tools ...

@apeltzer apeltzer added needs upstream fix Needs a fix in the upstream tool project pending Addressed on branch waiting for related PR labels Sep 16, 2019
@jfy133 jfy133 added the 2.1.0 label Sep 16, 2019
@apeltzer apeltzer added this to the V2.1 "Ulm" milestone Sep 16, 2019
@jfy133 jfy133 removed the 2.1.0 label Sep 16, 2019
@jfy133
Copy link
Member Author

jfy133 commented Nov 29, 2019

Coming this afternoon from @aidaanva

@aidaanva aidaanva mentioned this issue Nov 29, 2019
8 tasks
@jfy133
Copy link
Member Author

jfy133 commented Dec 1, 2019

Done in #292

@jfy133 jfy133 closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs upstream fix Needs a fix in the upstream tool project pending Addressed on branch waiting for related PR
Projects
None yet
Development

No branches or pull requests

2 participants