Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise base.configs #310

Closed
jfy133 opened this issue Dec 5, 2019 · 0 comments
Closed

Generalise base.configs #310

jfy133 opened this issue Dec 5, 2019 · 0 comments

Comments

@jfy133
Copy link
Member

jfy133 commented Dec 5, 2019

Is your feature request related to a problem? Please describe.

Base config is quite long at the moment with default resource settings for every process.

@maxulysse suggested to generalise the resources using labels.

i.e. in the base_config set the following

  withLabel:cpus_1 {
    cpus = {check_resource(1)}
  }

(https://github.com/nf-core/sarek/blob/4bdff8eed3e4bf1a4393b226d2e87f09c2346d35/conf/base.config#L22-L24)

And then in the main, add the label:

process FastQCFQ {
    label 'cpus_2'


    tag {idPatient + "-" + idRun}

Processes that still require very special resources (e.g. MALT) can still use the withName process selector

@jfy133 jfy133 added the minor label Dec 5, 2019
@jfy133 jfy133 self-assigned this Dec 5, 2019
@apeltzer apeltzer added this to the V2.1 "Ulm" milestone Dec 5, 2019
@jfy133 jfy133 closed this as completed Dec 20, 2019
@jfy133 jfy133 added this to Done in hackathon-scilifelab-2019 via automation Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants