Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run output documentationprocess does not export documentation images #374

Closed
jfy133 opened this issue Mar 30, 2020 · 3 comments
Closed

Run output documentationprocess does not export documentation images #374

jfy133 opened this issue Mar 30, 2020 · 3 comments
Assignees
@jfy133
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Mar 30, 2020 •
edited

This is related to nf-core/tools#391, and reported for nf-core/eager by @marcel-keller

We could in principle try checking where the paths link to (relative and absolute), and publishDir also the images alongside the md -> html file.

It shouldn't break linting, according to @apeltzer
@jfy133 jfy133 self-assigned this Mar 30, 2020
@jfy133 jfy133 added bug Something isn't working needs upstream fix Needs a fix in the upstream tool project labels Mar 30, 2020
@apeltzer
Copy link
Member

nf-core/viralrecon@c25d62a

This is the fix @jfy133

@apeltzer
Copy link
Member

Staging the images to the output_documentation process that generates the rendered report :D

@apeltzer apeltzer added 2.1.0 and removed needs upstream fix Needs a fix in the upstream tool project labels Apr 18, 2020
@apeltzer
Copy link
Member

Fixed in b2b411b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfy133 jfy133

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apeltzer @jfy133