Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenotypingGalore: add aDNA specific genotypers #451

Open
4 tasks
jfy133 opened this issue Jun 8, 2020 · 6 comments
Open
4 tasks

GenotypingGalore: add aDNA specific genotypers #451

jfy133 opened this issue Jun 8, 2020 · 6 comments
Assignees
Labels
DSL2 enhancement New feature or request feature question Further information is requested
Milestone

Comments

@jfy133
Copy link
Member

jfy133 commented Jun 8, 2020

A bunch of aDNA-aware genotypers have been released relatively recently.

We should add these as possible options

Here is a running list:

More might come, so will keep this for all.

@jfy133 jfy133 added this to the V2.3 "Wangen" milestone Jun 8, 2020
@jfy133 jfy133 added enhancement New feature or request feature labels Jun 8, 2020
@jfy133 jfy133 mentioned this issue Jun 8, 2020
@jfy133
Copy link
Member Author

jfy133 commented Jun 8, 2020

Note @sc13-bioinf already has made some work on snpAD:

I made a nextflow pipeline for snpAD so you can copy some of that if you want. The main reason my pipeline sucks is that it builds the substitution model for all chromosomes. You can just do that for one chromosome (or maybe X.Y.MT also if you really want) and then use that. Its in my HOMErepos/nextflow-snpAD but its not a git repo.

But that it doesn't appear avaliable on github, so might be difficult for conda packaging? https://bioinf.eva.mpg.de/snpAD/

@apeltzer
Copy link
Member

apeltzer commented Jun 8, 2020

Its a versioned URL (2.3.4), so one could just make a conda recipe for it - shouldn't be a problem.

@jfy133
Copy link
Member Author

jfy133 commented Jun 11, 2020

ANGSD is maybe a better for human shotgun too, according to @TCLamnidis , so should read recenr papers doing it and use those commands

@jfy133 jfy133 added the question Further information is requested label Jul 5, 2020
@jfy133
Copy link
Member Author

jfy133 commented Dec 22, 2020

Reviewer also requested samtools mpileup + bcftools, so we should include this in this release.

Example commands (from a snakemake pipeline):

	
" samtools mpileup -q30 -x -s -O -d3000 -f {input.ref} {input.bamA} > {output.pileup} ;" 
    " samtools mpileup -q30 -t SP -d3000 -vf {input.ref} {input.bamA} > {params.vcf_raw} ;"
    " bcftools call -c -Oz -o {output.vcf_strain} {params.vcf_raw} ;"
    " bcftools view -Oz -v snps -q .75 {output.vcf_strain} > {output.variants} ;"

@jfy133
Copy link
Member Author

jfy133 commented May 17, 2021

I've not really seen most of the tools used tbh (other than mpileup and very occasionally snpAD).

I think mpileup is very common in general so we should at that - but all the others arne't easily added to bioconda, not used, or produce EXTREMELY large output files apparently (snpAD), so I think until those become more widely used we can leave them out. THoughts @apeltzer ?

So 2.4 is add mpileup and then close this issue for now.

@apeltzer
Copy link
Member

Agreed

@jfy133 jfy133 reopened this May 21, 2021
@jfy133 jfy133 removed this from the 2.4 "Wangen" milestone Jul 18, 2021
@jfy133 jfy133 added the DSL2 label Sep 6, 2022
@jfy133 jfy133 added this to the 3.0 Augsburg milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSL2 enhancement New feature or request feature question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants