Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BAM Filtering input parameters less complex. #497

Closed
jfy133 opened this issue Jul 12, 2020 · 0 comments · Fixed by #502
Closed

Make BAM Filtering input parameters less complex. #497

jfy133 opened this issue Jul 12, 2020 · 0 comments · Fixed by #502
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers minor pending Addressed on branch waiting for related PR
Milestone

Comments

@jfy133
Copy link
Member

jfy133 commented Jul 12, 2020

Currently there are two logical flags relating to performing samtools filter, one to turn it on (and this assumes for mapQuality filtering) and then an additional to do something with unmapped reads.

From a user perspective this is a little confusing and users may forget to turn on the second flag when they specify how to remove the unmspped reads.

I suggest to remove the second flag and just have an option to do nothing to the unmapped reads (e.g. keep) to skip that functionality

@jfy133 jfy133 self-assigned this Jul 12, 2020
@jfy133 jfy133 added this to the V2.2 "Ulm" milestone Jul 12, 2020
@jfy133 jfy133 added good first issue Good for newcomers minor enhancement New feature or request labels Jul 12, 2020
@jfy133 jfy133 added this to Existing pipelines in hackathon-tasks Jul 13, 2020
@jfy133 jfy133 linked a pull request Jul 13, 2020 that will close this issue
8 tasks
@jfy133 jfy133 added the pending Addressed on branch waiting for related PR label Jul 13, 2020
@jfy133 jfy133 closed this as completed Jul 15, 2020
hackathon-tasks automation moved this from Existing pipelines to Done Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers minor pending Addressed on branch waiting for related PR
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant