Skip to content

Fix MALT staging and simplify unmapped read treatment#502

Merged
apeltzer merged 4 commits intodevfrom
malt-fix
Jul 15, 2020
Merged

Fix MALT staging and simplify unmapped read treatment#502
apeltzer merged 4 commits intodevfrom
malt-fix

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Jul 13, 2020

nf-core/eager pull request

This addresses two issues at once. Firstly it adds earlier checks for the presence of MALT(Extract) auxilary files (databases etc). It also simplifies the treatment of unmapped reads to remove the extra parameters. This closes #497 and #501.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker --paired_end).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@jfy133 jfy133 requested review from TCLamnidis, apeltzer and maxibor and removed request for apeltzer July 13, 2020 08:41
@jfy133 jfy133 self-assigned this Jul 13, 2020
@jfy133 jfy133 added this to the V2.2 "Ulm" milestone Jul 13, 2020
@jfy133 jfy133 changed the title Fix MALT staging and simplify unmapped read treatmetn Fix MALT staging and simplify unmapped read treatment Jul 13, 2020
@jfy133 jfy133 linked an issue Jul 13, 2020 that may be closed by this pull request
@apeltzer apeltzer merged commit 8dc14fe into dev Jul 15, 2020
@jfy133 jfy133 deleted the malt-fix branch July 16, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MALT databases are not correctly staged Make BAM Filtering input parameters less complex. Update/remove old test configs

2 participants