Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup gc overhead fix #498

Merged
merged 10 commits into from Jul 13, 2020
Merged

Dedup gc overhead fix #498

merged 10 commits into from Jul 13, 2020

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jul 12, 2020

nf-core/eager pull request

Includes a fix for DeDup not retrying correctly when crashiing (also addresses #478) and fixes emailing formatting working properly when occurs on fails.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker --paired_end).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@jfy133 jfy133 linked an issue Jul 12, 2020 that may be closed by this pull request
conf/base.config Show resolved Hide resolved
@jfy133 jfy133 merged commit 906b26b into dev Jul 13, 2020
@jfy133 jfy133 deleted the dedup-gc-overhead-fix branch July 20, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidExitstatus should be deprecated in code
2 participants