New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up strip_input_fastq process #327
Conversation
I don't see any issue code wise. I will run a big test on sdag to double check then will merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, mybig test shows massive improvement.
One small request: please move the publishDir outside samtools/
. An independent directory is valid IMO.
Then we are good for merging!
Done |
Merging - strip_fastq passes, tests hung on GATK UG Download which happens sometimes. |
Rewrite of
extract_map_reads.py
to speed it up and make it more robust:strip_input_fastq
Speed improvement
Wall time before (
strip_input_fastq
in green):Wall time after (
strip_input_fastq
in lightblue):PR checklist
nextflow run . -profile test,docker
).nf-core lint .
).CHANGELOG.md
is updatedLearn more about contributing: https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md