Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nuclear_contamination to MultiQC report as custom content. #511

Merged
merged 13 commits into from
Jul 16, 2020
Merged

Added nuclear_contamination to MultiQC report as custom content. #511

merged 13 commits into from
Jul 16, 2020

Conversation

TCLamnidis
Copy link
Collaborator

@TCLamnidis TCLamnidis commented Jul 15, 2020

Various changes:

  • Added latest version of Sex.DetERmine to environment.yaml. This version doesn't fail horribly when a bin has 0 coverage, instead setting the rates to 0.
  • Removed second barplot (snp_counts) from multiqc_report. Not that useful, but easier to hide it than to change MQC modules.

Nuclear_contamination changes:

  • Added nuclear contamination JSON output into multiQC
  • Order of columns fixed so they come after SexDet.

To Do:

  • Hide non default columns from nuclear_contamination output.
  • SampleID is not correctly assigned in some cases. When running with -profile test_tsv_humanbam, library entry is correctly assigned,but individual level entry has _rmdup added to Sample ID in the JSON. Looking into it.

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker --paired_end).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated

@TCLamnidis
Copy link
Collaborator Author

PR into docs-updates so the nuclear_contamination columns are added without conflicts.

Issues:
#504

@jfy133 jfy133 merged commit 9d75239 into nf-core:docs-updates Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants