Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory and error handling of qualimap #630

Merged
merged 3 commits into from Dec 11, 2020
Merged

Improve memory and error handling of qualimap #630

merged 3 commits into from Dec 11, 2020

Conversation

maxibor
Copy link
Member

@maxibor maxibor commented Dec 10, 2020 •
edited

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • CHANGELOG.md is updated.

@maxibor maxibor changed the title Improve memory and error hadnling of qualimap Improve memory and error handling of qualimap Dec 10, 2020
@maxibor maxibor requested a review from jfy133 December 10, 2020 14:31
jfy133
jfy133 approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for tests to pass then can merge 👍

@jfy133 jfy133 merged commit 7ead9a0 into nf-core:dev Dec 11, 2020
@jfy133
Copy link
Member

jfy133 commented Dec 11, 2020

Merci @maxibor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxibor @jfy133