Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template update v2.2 #122

Merged
merged 23 commits into from
Dec 15, 2021
Merged

Conversation

ggabernet
Copy link
Member

  • Template update to nf-core/tools v2.2
  • updated module structure to match new module template

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nxf_ver: ["21.10.4", ""]
include:
# Test pipeline minimum Nextflow version
- NXF_VER: '21.10.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why nextflow version 21.10.3 instead of 21.10.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right I mean this is the minimal version that should be tested, then the latest is also tested. So the minimal NXF_VER that still works for the pipeline should be cited here

@marissaDubbelaar
Copy link
Contributor

But it looks good to me!

Copy link
Collaborator

@christopher-mohr christopher-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question but looks good to me 👍.

docs/images/nf-core-epitopeprediction_logo_dark.png Outdated Show resolved Hide resolved
@ggabernet ggabernet merged commit 07f2be2 into nf-core:dsl2 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants