-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template update v2.2 #122
Template update v2.2 #122
Conversation
…merging-template-updates
…peprediction into merging-template-updates
nxf_ver: ["21.10.4", ""] | ||
include: | ||
# Test pipeline minimum Nextflow version | ||
- NXF_VER: '21.10.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why nextflow version 21.10.3 instead of 21.10.4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right I mean this is the minimal version that should be tested, then the latest is also tested. So the minimal NXF_VER that still works for the pipeline should be cited here
But it looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question but looks good to me 👍.
PR checklist
nf-core lint
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).