Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge template update #189

Merged
merged 5 commits into from Dec 23, 2022
Merged

Merge template update #189

merged 5 commits into from Dec 23, 2022

Conversation

christopher-mohr
Copy link
Collaborator

Template update and Nextflow version bump in ci.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Dec 22, 2022 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 32e5345

+| ✅ 158 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2022-12-22 16:12:09

@jonasscheid
Copy link
Contributor

Ah nice, I was also about to do the template merge :-D

Don't we need to remove all params.enable_conda in the local modules as well?
See here

@christopher-mohr
Copy link
Collaborator Author

Ah nice, I was also about to do the template merge :-D

Don't we need to remove all params.enable_conda in the local modules as well? See here

Good point. I will remove it.

@christopher-mohr christopher-mohr merged commit e261ee9 into nf-core:dev Dec 23, 2022
@christopher-mohr christopher-mohr deleted the merge_template_2_7_2 branch December 23, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasscheid jonasscheid jonasscheid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christopher-mohr @jonasscheid @nf-core-bot