Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nf-test #128

Closed
wants to merge 16 commits into from
Closed

nf-test #128

wants to merge 16 commits into from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller changed the title Nf test nf-test Nov 10, 2022
@edmundmiller edmundmiller changed the base branch from master to dev November 10, 2022 19:10
@nf-core nf-core deleted a comment from github-actions bot Nov 10, 2022
@github-actions
Copy link

github-actions bot commented Nov 10, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7c59fa6

+| ✅ 148 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-08 23:19:39

@edmundmiller edmundmiller marked this pull request as draft November 10, 2022 19:14
sateeshperi
sateeshperi reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

tests/pipeline/default/main.nf.test Outdated Show resolved Hide resolved
tests/pipeline/default/main.nf.test Outdated Show resolved Hide resolved
tests/pipeline/default/main.nf.test Outdated Show resolved Hide resolved
edmundmiller and others added 3 commits November 10, 2022 22:10
@edmundmiller @sateeshperi
test(pipeline): Add pipeline tests from GitHub Actions
f760669 
Co-authored-by: sateeshperi <sateeshperi@users.noreply.github.com>
@edmundmiller
ci: Copy ci from rnaseq
d10c105
@edmundmiller
ci: Use changes only
a5b1dca 
I think we can get away with a default tag
@edmundmiller edmundmiller self-assigned this Apr 21, 2023
@sateeshperi
Copy link
Contributor

closing this in favor of #151

@sateeshperi sateeshperi deleted the nf-test branch May 26, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi left review comments

@robsyme robsyme Awaiting requested review from robsyme

@maxulysse maxulysse Awaiting requested review from maxulysse

@drpatelh drpatelh Awaiting requested review from drpatelh

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edmundmiller @sateeshperi @maxulysse